chore: get rid of compiled dependencies by KuznetsovRoman · Pull Request #113 · gemini-testing/looks-same

KuznetsovRoman · 2025-08-07T22:38:03Z

No description provided.

KuznetsovRoman · 2025-08-07T22:39:35Z

README.md

 [![Build Status](https://travis-ci.org/gemini-testing/looks-same.svg?branch=master)](https://travis-ci.org/gemini-testing/looks-same)

-Node.js library for comparing images, taking into account human color
+Pure node.js library for comparing images, taking into account human color


We had this word 11 years ago:

KuznetsovRoman · 2025-08-07T22:40:17Z

benchmark/README.md

 3. Install dependencies:
   ```bash
-   npm ci
+   npm install


Removed package-lock because otherwise we would need to update it every time when looks-same package.json is updated

KuznetsovRoman · 2025-08-07T22:43:46Z

index.js

+    let rgbColor1 = {};
+    let rgbColor2 = {};
+    let labColor1 = {};
+    let labColor2 = {};


Implemented rgb -> lab conversion cache
It only stores last previous conversion
Considering we usually web screenshots, next pixel in line is usually the same as previous one, so it gives significant performance boost

KuznetsovRoman · 2025-08-07T22:45:14Z

index.js

+        if (areColorsSame({color1: data.color1, color2: rgbColor1})) {
+            lab1 = labColor1;
+        } else if (areColorsSame({color1: data.color1, color2: rgbColor2})) {
+            lab1 = labColor2;
+        }


Checking for "expected" cache colours for "actual" image and vice versa helps with moved objects (like borders)

KuznetsovRoman · 2025-08-07T22:46:23Z

index.js


    const highlightColor = options.highlightColor;
-    const resultBuffer = Buffer.alloc(width * height * 3);
+    const resultBuffer = Buffer.allocUnsafe(width * height * RGB_IMAGE_CHANNELS);


"allocUnsafe", compared to "alloc", does not fill buffer with zeroes
Which is totally fine for us, because we fill the buffer ourselves

KuznetsovRoman · 2025-08-07T22:47:58Z

lib/diff-clusters/clusters-joiner.js

+/**
+ * @type import('js-graph-algorithms')
+ */
+const jsgraphs = require('../vendor/jsgraphs.min.js');


"jsgraphs" package ships large "third-party-libs" directory:

KuznetsovRoman · 2025-08-07T22:51:10Z

lib/image/image.js

    async createBuffer(extension) {
-        return this._img.toFormat(extension).toBuffer();
+        if (extension === 'raw') {


looks-same/index.d.ts

Line 64 in ed93f8c

createBuffer: (extension: "png" | "raw") => Promise<Buffer>;

KuznetsovRoman · 2025-08-13T14:16:06Z

lib/image/image.js

-        this._width = width;
-        this._height = height;
-        this._channels = channels;
+    async init() {


"jsquash/png" decode result is a promise. Until it resolves, we can't get access to rbg bytes
"getPixel" is sync

KuznetsovRoman · 2025-08-14T09:32:42Z

README.md

-## Supported image formats
-
-JPEG, PNG, WebP, GIF, AVIF, TIFF and SVG images are supported.
-
-*Note: If you want to compare jpeg files, you may encounter random differences due to the jpeg structure if they are not lossless jpeg files.*
-


Breaking change

KuznetsovRoman · 2025-08-14T09:34:35Z

lib/image/eight-bit-rgba-to-png.js

+
+const convertRgbaToScanlines = (rgba, width, height) => {
+    const stride = width * PNG.RGBA_CHANNELS;
+    const scanlines = Buffer.allocUnsafe(height * (1 + stride)); // extra byte for filter


"allocUnsafe" is faster, because it does not fill the buffer with zeroes, leaving trash data
thats fine, because we fill it all the way
And thats safe, because we throw, if for some reason buffer wasn't rewritten fully (which would not happen)

KuznetsovRoman · 2025-08-14T09:36:22Z

lib/image/eight-bit-rgba-to-png.js

+    return scanlines;
+}
+
+exports.convertRgbaToPng = (rgba, width, height, compressionLevel = COMPRESSION_LEVEL) => {


Just formatting data to https://www.w3.org/TR/PNG-Chunks.html standards
8 bit rgba deflate png without filter or interlace

KuznetsovRoman · 2025-08-14T09:54:48Z

package.json

+    "parse-color": "^1.0.0"
  },
  "devDependencies": {
+    "@eslint/js": "^8.57.1",


старый eslint ругался на динамический импорт

DudaGod

🔥

DudaGod · 2025-08-18T09:14:50Z

lib/image/eight-bit-rgba-to-png.js

+    if (pointer !== resultBuffer.byteLength) {
+        throw new Error("Got malformed input while trying to convert rgba to png");
+    }
+    return resultBuffer;


I didn't look at this piece of code carefully. I hope you did everything correctly according to the specification.

DudaGod · 2025-08-18T09:18:15Z

lib/utils.js

        diffBuffer[diffBufferPos++] = diffColor.R;
        diffBuffer[diffBufferPos++] = diffColor.G;
        diffBuffer[diffBufferPos++] = diffColor.B;
+        diffBuffer[diffBufferPos++] = 0xff;


why we need to add alpha channel?

"eight-bit-rgba-to-png" only converts rgba to png, not rgb to png
I checked difference between rgba and rgb weight, and there is no result image size difference because of how deflate works: for a large image its like "9.5M RGBA" vs "9.4M RGB"

chore: reduce deps size

ea3dc47

KuznetsovRoman force-pushed the TESTPLANE-653.bin branch from e94f720 to d97b7a9 Compare August 7, 2025 22:41

KuznetsovRoman commented Aug 7, 2025

View reviewed changes

KuznetsovRoman force-pushed the TESTPLANE-653.bin branch 2 times, most recently from b7218bd to 17354cb Compare August 7, 2025 23:00

KuznetsovRoman mentioned this pull request Aug 11, 2025

Bump sharp to 0.34.0 #110

Closed

KuznetsovRoman force-pushed the TESTPLANE-653.bin branch 6 times, most recently from 301a0ee to 0890092 Compare August 14, 2025 09:10

KuznetsovRoman commented Aug 14, 2025

View reviewed changes

KuznetsovRoman force-pushed the TESTPLANE-653.bin branch 2 times, most recently from 3742126 to 68bc878 Compare August 14, 2025 09:51

KuznetsovRoman commented Aug 14, 2025

View reviewed changes

KuznetsovRoman force-pushed the TESTPLANE-653.bin branch from 68bc878 to cc2e246 Compare August 14, 2025 12:28

KuznetsovRoman added 2 commits August 14, 2025 16:01

chore!: migrate sharp -> jsquash/png

89cf122

docs(benchmark): update benchmarks

982b367

KuznetsovRoman force-pushed the TESTPLANE-653.bin branch from cc2e246 to 982b367 Compare August 14, 2025 13:01

DudaGod approved these changes Aug 18, 2025

View reviewed changes

KuznetsovRoman merged commit fbd86df into master Aug 18, 2025
2 checks passed

KuznetsovRoman deleted the TESTPLANE-653.bin branch August 18, 2025 18:27

Conversation

KuznetsovRoman commented Aug 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DudaGod left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants